Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused scale classes #9495

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Remove unused scale classes #9495

merged 2 commits into from
Aug 29, 2023

Conversation

alrod
Copy link
Member

@alrod alrod commented Aug 28, 2023 •
edited
Loading

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@alrod alrod requested a review from a team as a code owner August 28, 2023 23:25
@alrod alrod force-pushed the alrod/remove-unused branch from b4e5846 to de46beb Compare August 29, 2023 16:22
@kshyju
Copy link
Member

kshyju commented Aug 29, 2023

Is the test failure caused by this file deletion?

@mathewc
Copy link
Member

mathewc commented Aug 29, 2023

Is the test failure caused by this file deletion?

Yes - he needs to update the csproj to remove the file entry

@alrod alrod merged commit daf6981 into dev Aug 29, 2023
@alrod alrod deleted the alrod/remove-unused branch August 29, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem approved these changes

@mathewc mathewc mathewc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alrod @kshyju @mathewc @liliankasem